[Issue #4108] fn_parameter_post_comment_alignment config option#6930
Draft
Ripper53 wants to merge 1 commit into
Draft
[Issue #4108] fn_parameter_post_comment_alignment config option#6930Ripper53 wants to merge 1 commit into
Ripper53 wants to merge 1 commit into
Conversation
Contributor
|
I don't think it makes sense to support a bespoke |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Add config to format like from this issue: #4108
Currently, this code:
Is formatted into this:
This can confuse the reader into thinking that the two comments are related or follow each other, even when they are unrelated.
Changes
Add a config option of
fn_post_comment_alignmentthat has two options:SameIndentSingleSpaceThe
SameIndentoption preserves the current behavior, while theSingleSpaceis the new behavior.To make the configuration highly customizable, the
write_listfunction takes an additionalPostCommentAlignmentparameter now. This will allow different behavior in different places, like in match statements or imports.